Try harder to keep update cached recipe#2264
Open
npostavs wants to merge 4 commits intodimitri:masterfrom
Open
Try harder to keep update cached recipe#2264npostavs wants to merge 4 commits intodimitri:masterfrom
npostavs wants to merge 4 commits intodimitri:masterfrom
Conversation
Merged
The button types for install, update, and remove now use `el-get-pkg-op' as their supertype, instead of `help-xref'; the buttons for jumping to recipe file, and install directory use `el-get-file-jump'. Since these buttons don't actually affect the *Help* buffer, the xref functionality was not useful. Rename `el-get-describe-princ-button' -> `el-get-fmt-button'. Instead of requiring a regex to pick out the button label from its surrounding text, pass the a format string and label directly. It returns the button to be inserted in the buffer, rather than inserting it directly. Note that `princ'ing buttons does not work because princ doesn't pass through string properties; simply change all princ to insert.
Never throw an error about not updated properties, just warn about them.
Also, allow prefix arguments to el-get-merge-properties-into-status to specify updating as if doing update or reinstall operations.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Let the safe properties be updated even if others are not known to be safe. This is a prequisite to solving #2232. See also #2238 (comment). Fixes #2359.
Additionally, always use
display-warningwhen properties can't be updated instead of hiding the warning in the*Messages*buffer. This can be suppressed by adding(el-get recipe-cache)towarning-suppress-types, which is the standard Emacs mechanism for supressing warnings, but it's not very discoverable so some users may find the warnings annoying. I added the actions needed to fix the problems into warnings themselves in the form of clickable links/buttons, so hopfully it won't be too bad.There are errors during self update again, so I'll see if I can add some backwards compat code to smooth it out before merging this.
transition install seems okay,
but I just got
fixed, was a stupid mistake.el-get-describe-1: Symbol's function definition is void: el-get-insert-buttonneed to double check that.
el-get-compute-new-statusis returning wrong result for theREQUIREDpart.